This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Fix code generation path escaping #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
A: tooling
zeroZshadow
approved these changes
Jun 17, 2019
jessicafalk
approved these changes
Jun 17, 2019
|
This resolves #992 |
paulbalaji
approved these changes
Jun 17, 2019
jessicafalk
pushed a commit
that referenced
this pull request
Nov 15, 2019
* * Integrated the Development Authentication Flow
* Added a few options in SpatialGDKSettings
* * Refactor the callback code to check failure first;
* Add more information to the failure message;
* Update SpatialGDK/Source/SpatialGDK/Public/SpatialGDKSettings.h
Co-Authored-By: jessicafalk <31853332+jessicafalk@users.noreply.github.com>
* * Move the player id string for development authentication to SpatialConstants.
* Update SpatialGDK/Source/SpatialGDK/Private/Interop/Connection/SpatialWorkerConnection.cpp
Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io>
* Update SpatialGDK/Source/SpatialGDK/Private/Interop/Connection/SpatialWorkerConnection.cpp
Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io>
* * Removed bConnectLocalServerWorker to follow 'spatial connect external' flow;
* Added #pragma optimize("", off) to prevent the strange behaviour of TCHAR_TO_UTF8;
* Changed the log level from Log to Error;
* Moved some magic strings and numbers to SpatialConstants;
* Updated some comment and header include;
* * Adapted Worker API change in 13.7.1
* * Renamed the category of the 'Cloud Test' to 'Cloud Connection';
* Removed FinishDevelopmentAuth();
* Removed '#pragma optimize';
* The worker API parameters are now allocated in stack rather than heap.
* Update SpatialGDK/Source/SpatialGDK/Private/Interop/Connection/SpatialWorkerConnection.cpp
Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io>
* Update SpatialGDK/Source/SpatialGDK/Private/Interop/Connection/SpatialWorkerConnection.cpp
Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io>
* * Used LOCATOR_HOST constant in FLocatorConfig;
* Used named FTCHARToUTF8 object to convert string;
* * Fleshed out the SUCCESS message when received PIT and LT;
* * Fix variables naming to capital
* Update SpatialGDK/Source/SpatialGDK/Private/Interop/Connection/SpatialWorkerConnection.cpp
Co-Authored-By: Sahil Dhanju <Vatyx@users.noreply.github.com>
* * Updated the changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See title. There were a few un-escaped paths.
Changelog incoming