Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xml version and encoding type #20

Merged
merged 3 commits into from May 22, 2017
Merged

Add xml version and encoding type #20

merged 3 commits into from May 22, 2017

Conversation

kamrava
Copy link
Contributor

@kamrava kamrava commented May 22, 2017

Now, users can specify XML version and the encoding type

@freekmurze
Copy link
Member

Coudl you also add a test for the XML version parameter?

@kamrava
Copy link
Contributor Author

kamrava commented May 22, 2017

Yes of course. just gimme 5 minutes :)

@kamrava
Copy link
Contributor Author

kamrava commented May 22, 2017

Test for XML version has been added.

@freekmurze freekmurze merged commit 9f29c71 into spatie:master May 22, 2017
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kamrava @freekmurze