Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child process is not stop when we call method markAsTimedOut it continue work on background #104

Closed
alexspark21 opened this issue Jan 9, 2020 · 6 comments

Comments

@alexspark21
Copy link

I detect some problem when call command in linux terminal ps aux | grep ChildRuntime.php | wc -l result it is number of running processes in system.
My setting for Pool object concurrency - 5 and timeout - 2.
When we check expression

if ($process->getCurrentExecutionTime() > $this->timeout) {

we call markAsTimedOut but the child process is not stoped it continue work on background

@brendt
Copy link
Contributor

brendt commented Jan 10, 2020

The process should indeed be killed, which doesn't happen right now. Are you able to submit a PR?

@alexspark21
Copy link
Author

@brendt #105

@spatie-bot
Copy link

Dear contributor,

because this issue seems to be inactive for quite some time now, I've automatically closed it. If you feel this issue deserves some attention from my human colleagues feel free to reopen it.

@alexspark21
Copy link
Author

Hello @brendt pls could you check PR #105

@brendt
Copy link
Contributor

brendt commented Aug 14, 2020

Yes, I lost track of this one. Will check it next week!

@brendt brendt reopened this Aug 18, 2020
@brendt
Copy link
Contributor

brendt commented Aug 19, 2020

Fix in 1.4.1: https://github.com/spatie/async/releases/tag/1.4.1

@brendt brendt closed this as completed Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants