Skip to content
This repository has been archived by the owner on Dec 10, 2018. It is now read-only.

[Idea] Split up HasBinaryUUID trait #64

Closed
afraca opened this issue Sep 10, 2018 · 2 comments
Closed

[Idea] Split up HasBinaryUUID trait #64

afraca opened this issue Sep 10, 2018 · 2 comments

Comments

@afraca
Copy link

afraca commented Sep 10, 2018

The HasBinaryUUID trait is quite 'all in'. It's not so easy to mix how your models work.

If your model A does not have binary uuid, but B has, and you're working with relations, it's nice to have the toArray() from the trait, but I don't want the creating listener code.

@brendt
Copy link
Contributor

brendt commented Sep 10, 2018

There actually were multiple traits in a previous version. We decided to go all in for a better default user experience. For some people this is a good thing, for other it's not.

Furthermore, this would mean a breaking change. I'll tag this issue so that we'll revisit it for a next major version.

@vpratfr
Copy link
Collaborator

vpratfr commented Sep 10, 2018

Note for later. A non breaking way to do that would be to split it in several traits and then the existing trait would use all those smaller pieces.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants