Skip to content
This repository has been archived by the owner on Dec 10, 2018. It is now read-only.

Relies on static UUID factory not being changed #84

Closed
uphlewis opened this issue Nov 8, 2018 · 3 comments
Closed

Relies on static UUID factory not being changed #84

uphlewis opened this issue Nov 8, 2018 · 3 comments

Comments

@uphlewis
Copy link

uphlewis commented Nov 8, 2018

Currently the library sets the static default Uuid factory with OrderedTimeCodec at boot in the package service provider.

The issue is where somewhere else in the application changes the static factory and uses a different codec.

Solution is to register a singleton OrderedTimeCodec in the service container, and resolve the instance whenever it is needed.

Will submit a PR.

Thanks for the library :) Although it's not quite suitable for my needs, I was able to adapt some ideas for my own project.

@brendt
Copy link
Contributor

brendt commented Nov 8, 2018

Thanks! Feel free to submit a PR.

@uphlewis
Copy link
Author

PR submitted: #85

@freekmurze
Copy link
Member

We'll continue the conversation in #85

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants