Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append values to the existing namespace instead of override. #38

Closed
nesskyy opened this issue Nov 23, 2018 · 1 comment
Closed

Append values to the existing namespace instead of override. #38

nesskyy opened this issue Nov 23, 2018 · 1 comment

Comments

@nesskyy
Copy link

nesskyy commented Nov 23, 2018

Hi! In some situations, to keep consistency, there is a need to use the same window namespace for custom solutions as we might use for assigning data via @javascript(). Current implementation of the module overrides data that have been declared before @javascript(). What do you think about appending data to the namespace if such already exists (and maybe even make it configurable?) instead of just clearing that?

@freekmurze
Copy link
Member

I'd like to keep this package very simple. Currently it supports only our usecases. If you need extra funtionality, feel freek to fork our code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants