Allow overriding the CheckFailedNotification class

[moisish]

At the moment you can change the config file notifications.notifications but the class is harcoded on the RunHealthChecksCommand command and it's not possible to use your own

[freekmurze]

Using the first key seems a bit dirty to me. In the latest version, I've made it easy to override the notification class name to use.

[moisish]

Hello @freekmurze

Since you are using an array on the config file, it's the only way to use array_first.

I can see you added a method getFailedNotificationClass but that means we need to override the RunHealthChecksCommand class.
Why do we defined the class on the config file if you cannot change it in one place?

[moisish]

Another solution will be to change the config file and split the class and channels something like

'channels' => [
            'mail',
            'slack'
        ],
'notification' => Spatie\Health\Notifications\CheckFailedNotification::class

Let me know if this solution is acceptable and I will submit a new PR

[Nonslas]

I had same issue, should I make new command extend RunHealthChecksCommand to override method getFailedNotificationClass?

[moisish]

@freekmurze can we reopen this please?