Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Message - Add Environment Name with Application Name #103

Merged
merged 1 commit into from Jun 30, 2022

Conversation

moisish
Copy link
Contributor

@moisish moisish commented Jun 29, 2022

When you have multiple environments for the same app, it makes sense to display the environment name on all the messages.

Some of the health checks on Laravel App [local] have failed

Some of the health checks on Laravel App [qa] have failed

@freekmurze
Copy link
Member

I like the env name being passed to the translations, but I don't like the translations themselves showing it by default. Could you revert the changes to the translation files?

@moisish
Copy link
Contributor Author

moisish commented Jun 30, 2022

@freekmurze I have reverted the changes on the translation files.

I also came up with a better way to pass parameters on the translation files which allows more customisation

@freekmurze freekmurze merged commit 8c97f23 into spatie:main Jun 30, 2022
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants