No collection fallback when using getTemporaryUrl

[nessor]

PHP: v7.4.5
Laravel: v7.9.2
Media Library: 8.2.7

Hey guys,

I have noticed that apparently when using the function getTemporaryUrl the fallback url from the collection is not used.

The collection:

public function registerMediaCollections(): void
    {
        $this
            ->addMediaCollection('avatars')
            ->useFallbackUrl('/images/backend/no-avatar.png')
            ->useFallbackPath(public_path('/images/backend/no-avatar.png'));
    }

The call:

<img src="{{ Auth::user()->getFirstMedia('avatars')->getTemporaryUrl(\Carbon\Carbon::now()->addMinutes(10)) }}" alt="avatar">

The error:

Call to a member function getTemporaryUrl() on null

But when I try to call the getFirstMediaUrl function everything is working fine

<img src="{{Auth::user()->getFirstMediaUrl('avatars')}}" alt="avatar">

Am I doing something wrong or can someone validate the problem?

[freekmurze]

I accept a PR that improves this behaviour.

[nessor]

@freekmurze
Little question on the side.
I'm in the middle of writing tests. But since I'm developing on Windows, it's totally annoying with the paths.

I get the following faild test:

4) Spatie\MediaLibrary\Tests\Feature\Media\GetPathTest::it_can_get_a_path_of_a_derived_image
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'C:\GitLab\laravel-medialibrary\tests/TestSupport/temp/media/1/conversions/test-thumb.jpg'
+'C:\GitLab\laravel-medialibrary\tests/TestSupport/temp/media\1/conversions/test-thumb.jpg'

C:\GitLab\laravel-medialibrary\tests\Feature\Media\GetPathTest.php:27

Is it perhaps useful to replace all "\" with "/" in the tests? Or could any other problems arise then?

[freekmurze]

Yeah, than it won't work on Unix based systems. Maybe you can solve this by using DIRECTORY_SEPARATOR somewhere.

[DenMette]

Hi @freekmurze,

After some digging into the codebase, I think it will break more stuff than necessary to make it work. When I send back a new Media object, other test are failing hard. Maybe an optional could be a solution on the long run.

@nessor can't you use:

// Your code
Auth::user()->getFirstMedia('avatars')->getTemporaryUrl(\Carbon\Carbon::now()->addMinutes(10))

// What I suppose it needs to be
// filename: InteractsWithMedia.php for more information
Auth::user()->getFirstTemporaryUrl(\Carbon\Carbon::now()->addMinutes(10), 'avatars')

[nessor]

@DenMette Idk. Unfortunately, I have so less time at the moment, that I could not continue to work on it :(

[freekmurze]

Closing this due to inactivity.