Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile sizes #2

Closed
rawcreative opened this issue May 17, 2015 · 3 comments
Closed

Profile sizes #2

rawcreative opened this issue May 17, 2015 · 3 comments

Comments

@rawcreative
Copy link

In the Readme it says the getImageProfileProperties method can be placed on the Model to define profiles that will be created for each image associated with the model. Defining this however doesn't seem to do anything, and I can't find any calls to that method in the codebase. Am I missing something or is this just not implemented?

@rawcreative
Copy link
Author

Digging a little deeper it appears the GlideImageManipulator:: getModelImageProfiles() method, looks for the imageProfiles attribute on the model. So changing getImageProfileProperties to getImageProfilesAttribute returns the profiles properly, however it only appears to create one profile image unless shouldBeQueued is set to false. I've tried with both the sync queue driver and beanstalk, and it seems only the first profile is being queued.

@freekmurze
Copy link
Member

I've taken a look at the code and there are indeed some problems with the image profile properties.

@freekmurze
Copy link
Member

The problems you described have been fixed in version 1.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants