Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

route() method has only 3 args, 4 passed. #42

Closed
mathieutu opened this issue Feb 17, 2017 · 3 comments
Closed

route() method has only 3 args, 4 passed. #42

mathieutu opened this issue Feb 17, 2017 · 3 comments

Comments

@mathieutu
Copy link

mathieutu commented Feb 17, 2017 •
edited
Loading

Hi guys,
on your $menu->route() method, you consider 4 arguments, but at the end the \Illuminate\Routing\UrlGenerator::route accept only three.

Am I missing something, or the last parameter \Illuminate\Routing\Route $route is useless?

Thanks.
Matt'

screen shot 2017-02-17 at 18 59 10

screen shot 2017-02-17 at 18 57 19
@sebastiandedeyne
Copy link
Member

Apparently this used to be a thing: https://github.com/laravel/framework/pull/13206/files

Tagged a new release without the $route parameter!

@freekmurze
Copy link
Member

Hey @mathieutu,

see you at Laracon EU this year?

@mathieutu
Copy link
Author

Hi @freekmurze!
Obviously! What else? 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@freekmurze @sebastiandedeyne @mathieutu