Unresolvable dependency error when using V8 engine

[robinvdvleuten]

Hi there! When using the V8 engine, I run in the following exception;

Unresolvable dependency resolving [Parameter #0 [ <optional> $object_name ]] in class V8Js

It looks like I can solve the issue by adding;

$this->app->singleton(V8::class, function () {
    return new V8(new \V8Js());
});

But I do not know if that's the "Laravel" way.

[sebastiandedeyne]

Are you sure the V8Js extension is installed and available?

[robinvdvleuten]

Yes because when I run it as mentioned in my issue it resolves without errors

[sebastiandedeyne]

Hmm didn't come across this myself, odd.

Made some IoC changes though, does the latest release (0.2.4) solve this?

[robinvdvleuten]

Still getting the error unfortunately with the latest version. Somehow Laravel don't detects that they are optional. Maybe it's an idea to make them configurable?

[sebastiandedeyne]

Alright, really solved this issue in 0.2.5 using your proposed snippet. Feels like the cleanest way to go :)

[robinvdvleuten]

@sebastiandedeyne thanks!

[JamesPJ]

I'm able to reproduce this issue in version ^1.3. To make sure I'm having the v8js installed properly. I've cloned this https://github.com/reactjs/react-php-v8js/tree/master/example example and excecuted it locally. It worked fine.