Add option to check soft deleted models for uniqueness #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fails on Laravel 5.1 https://travis-ci.org/spatie/laravel-sluggable/jobs/168503651#L368 Could you fix that error? |
|
I wasn't able to figure it out yet. It looks like the issue is with Laravel 5.2's SoftDeletes. I'll work on it again tonight. Feel free to throw any pointers my way. |
|
Actually, I just looked at your comment again @freekmurze, I'm not sure but looking at the raw log from travis here isn't it installing 5.2? If I remember correctly, 5.2 is what was installed on my machine when I ran Does that sound right? |
|
You're right, it's in Laravel 5.2 that this PR fails |
|
Hi, because in our projects we're probably never going to use soft deletes, I've decided to not merge this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to address #12. I apologize if this isn't what the author intended but I think I understood correctly.
I'm not sure about the naming and I'm open to feedback.
I just realized for forgot to update the readme. Let me know if you intend to pull this in and I'll update it.