Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not using the default app.fallback_locale config option? #6

Closed
Omranic opened this issue May 9, 2016 · 3 comments
Closed

Why not using the default app.fallback_locale config option? #6

Omranic opened this issue May 9, 2016 · 3 comments

Comments

@Omranic
Copy link
Contributor

Omranic commented May 9, 2016

First of all thanks for this awesome package, neat and elegant API. The cleanest, easiest, and most intuitive translatable Eloquent models API actually.

My question is: Why do you duplicate the fallback_locale config option and not using the default app.fallback_locale for locale fallback, just like the app.locale ?

@freekmurze
Copy link
Member

Hi, thanks for you kind words on our package. Greatly appreciated.

I simply forgot that app.php did already contain a fallback_locale. Changing this now, would be a breaking change. I'll correct this is the next major version of the package.

@Omranic
Copy link
Contributor Author

Omranic commented May 12, 2016

Appreciated @freekmurze

One more thing, are you interested in the following features sent in a PR?

  • Add support for multiple translation forgot: forgetTranslations
  • Fire event on forgetTranslation like in setTranslation

@freekmurze
Copy link
Member

Hi, I'd probably accept a PR with those features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants