Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure script: packages with dashes (-) will create invalid PHP code in README usage section #47

Closed
levu42 opened this issue Aug 2, 2021 · 0 comments

Comments

@levu42
Copy link

levu42 commented Aug 2, 2021

Hello! If I create a package with a - in the package name, the usage section in the README uses the dashes directly for a variable name, resulting in incorrect PHP.

Example: Running the configure script with vendor = Me, package name = my-first-package, class name = MFP results in:

## Usage
```php
$my-first-package = new Me\MPF();

when it should convert the variable name e.g. with slugify to $myfirstpackage.

Thanks for the great video course & this helpful skeleton!

@spatie spatie locked and limited conversation to collaborators Aug 4, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants