Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query params with name starting with reg are incorrectly interpreted as HTML &reg entities #925

Open
ceilidhboy opened this issue Jun 19, 2024 · 0 comments

Comments

@ceilidhboy
Copy link

ceilidhboy commented Jun 19, 2024

Describe the bug
With ray()->showHttpClientRequests(), URLs with query params with name starting with reg are incorrectly interpreted and displayed in Ray as the HTML registered trademark entity ® when they are not the first param.

This seems to be due to Ray interpreting &reg in the URL as an HTML entity

For example, the query https://fubar.com?foo=bar&regNo=1 is displayed as https://fubar.com?foo=bar®No=1

EDIT:
The same error happens when calling ray->link(). Try ray()->link('https://fubar.com?foo=bar&regNo=1'); and you get the following screenshot

2024-06-19 13_43_44-Ray

Versions
Ray version 2.8.1.0

  • spatie/ray package version: 1.41.2
  • spatie/laravel-ray package version (if applicable): 1.36.2

PHP version: 8.2
Laravel version: 11.10.0

To Reproduce
Steps to reproduce the behavior:

  1. ray()->showHttpClientRequests();
  2. Send an HTTP request with the query string ?foo=bar&regNo=1.

Expected behavior
To see the query string displayed in Ray as ?foo=bar&regNo=1.

Screenshots
2024-06-19 11_47_32-Ray

Desktop (please complete the following information):

  • OS: Windows
  • Version 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant