Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information to README.md about using NVM #10

Merged
merged 1 commit into from Jan 12, 2022

Conversation

Drewdan
Copy link
Contributor

@Drewdan Drewdan commented Jan 12, 2022

Hey Guys!

I tried out the spatie/markdown package yesterday and I got stuck on why it would not render properly. It transpires the issue was that I use NVM, and the package was looking for node in a particular place, where it was not. It took me far longer to realize that this was what was happening, and required the help of someone in the Laracasts forum too!

My first though was to update the package to accept another variable, so the user could specify the location of their node executable. But then I decided it probably made more sense just to symlink the file instead, as the likelihood is, in production, node would be installed instead of NVM, so it's less of an issue.

I figured it would be good to add this to the readme, to help anyone else that gets stuck. If this PR is accepted, I will also make a similar on one the spatie/markdown package too!

Thanks Guys :)

@riasvdv riasvdv merged commit 7a7c71d into spatie:main Jan 12, 2022
@riasvdv
Copy link
Member

riasvdv commented Jan 12, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants