Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop requirement for yidas/yii2-bower-asset #2

Closed
yuniorsk opened this issue Jan 29, 2021 · 2 comments
Closed

Drop requirement for yidas/yii2-bower-asset #2

yuniorsk opened this issue Jan 29, 2021 · 2 comments

Comments

@yuniorsk
Copy link
Contributor

Hi, I am not sure if the requirement for yidas/yii2-bower-asset is a good call here, as it should be up to the developers to decide how they handle assets management in their yii2 projects. This package is not universal solution and does not fit every scenario (like here) so it's should not be forced upon project via another package.
@riasvdv
Copy link
Member

riasvdv commented Jan 29, 2021

It was needed for the tests to work somehow, I'll see if moving it to dev-dependencies works well, or if you can PR this then I'd be glad to merge it

@yuniorsk yuniorsk mentioned this issue Jan 29, 2021
Merged
@riasvdv
Copy link
Member

riasvdv commented Feb 1, 2021

Fixed in 1.2.1!

@riasvdv riasvdv closed this as completed Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuniorsk @riasvdv