Bugfix: Wait for rules to be processed before trying to validate them

spautz · May 19, 2021 · f0f4047 · f0f4047
1 parent d778487
commit f0f4047
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/packages/packagelint/lib-src/prepare/accumulateRules.ts b/packages/packagelint/lib-src/prepare/accumulateRules.ts
@@ -22,7 +22,7 @@ async function accumulateRules(
 ): Promise<Array<PackagelintPreparedRule>> {
   const accumulator = new RuleAccumulator();
 
-  accumulator.accumulateRuleList(packagelintConfig.rules);
+  await accumulator.accumulateRuleList(packagelintConfig.rules);
 
   return accumulator.getPreparedRuleList();
 }
@@ -42,10 +42,13 @@ class RuleAccumulator {
   accumulateRuleList(
     ruleList: Array<PackagelintRuleEntry | PackagelintRulesetEntry>,
     overrides?: Partial<PackagelintRuleConfig>,
-  ): void {
-    ruleList.forEach((ruleInfo: PackagelintRuleEntry | PackagelintRulesetEntry) => {
-      this.accumulateRule(ruleInfo, overrides);
-    });
+  ): Promise<void> {
+    const allPendingRules = ruleList.map(
+      (ruleInfo: PackagelintRuleEntry | PackagelintRulesetEntry) => {
+        return this.accumulateRule(ruleInfo, overrides);
+      },
+    );
+    return Promise.all(allPendingRules).then();
   }
 
   /**