Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support enum dynamic constant #241

Closed
koraga opened this issue Jan 21, 2024 · 8 comments · Fixed by #242 or #248
Closed

Add support enum dynamic constant #241

koraga opened this issue Jan 21, 2024 · 8 comments · Fixed by #242 or #248

Comments

@koraga
Copy link

koraga commented Jan 21, 2024 •
edited by spaze

PHP: 8.3.1
When i use dynamic constants for enum.
For example:

<?php declare(strict_types = 1);

enum Foo
{
	case Bar;
}

$variable = 'Bar';
$const = Foo::{$variable};

https://phpstan.org/r/fc74146a-7438-4cd8-ae4c-56c8db97dad5

Screenshot

Screenshot 2024-01-21 at 4 04 15 PM

I catch error

Uncaught PHPStan\ShouldNotHappenException: $node->name should be PhpParser\Node\Identifier but is PhpParser\Node\Expr\PropertyFetch in /api/vendor/spaze/phpstan-disallowed-calls/src/Usages/ClassConstantUsages.php: 84
#0 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/FileAnalyser.php(107): Spaze\PHPStan\Rules\Disallowed\Usages\ClassConstantUsages->processNode(Object(PhpParser\Node\Expr\ClassConstFetch), Object(PHPStan\Analyser\MutatingScope))
#1 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Node/ClassStatementsGatherer.php(108): PHPStan\Analyser\FileAnalyser->PHPStan\Analyser\{closure}(Object(PhpParser\Node\Expr\ClassConstFetch), Object(PHPStan\Analyser\MutatingScope))
#2 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(567): PHPStan\Node\ClassStatementsGatherer-> __ invoke(Object(PhpParser\Node\Expr\ClassConstFetch), Object(PHPStan\Analyser\MutatingScope)
#3 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(2653): PHPStan\Analyser\NodeScopeResolver: : PHPStan\Analyser\{closure}(Object(PhpParser\Node\Expr\ClassConstFetch), Object(PHPStan\Analyser\MutatingScope))
#4 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(1592): PHPStan\Analyser\NodeScopeResolver->callNodeCallbackWithExpression(Object(Closure), Object(PhpParser\Node\Expr\ClassConstFetch), Object(PHPStan\Analyser\MutatingScope), ObjectPHPStan\Analyser\ExpressionContext))
#5 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(605): PHPStan\Analyser\NodeScopeResolver->processExprNode(Object(PhpParser\Node\Stmt\Return_), Object(PhpParser\Node\Expr\ClassConstFetch), Object(PHPStan\Analyser\MutatingScope), Object(Closure), Object(PHPStan\Analyser\ExpressionContext))
#6 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(401): PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\Return_), Object(PHPStan\Analyser\MutatingScope), Object(Closure), Object(PHPStan\Analyser\StatementContext))
#7 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(566): PHPStan\Analyser\NodeScopeResolver->processStmtNodes(Object(PhpParser\Node\Stmt\ClassMethod), Array, Object(PHPStan\Analyser\MutatingScope), Object(Closure), Object(PHPStan\Analyser\StatementContext))
#8 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(401): PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\ClassMethod), Object(PHPStan\Analyser\MutatingScope), Object(PHPStan\Node\ClassStatementsGatherer), Object(PHPStan\Analyser\StatementContext))
#9 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(668): PHPStan\Analyser\NodeScopeResolver->processStmtNodes(Object(PhpParser\Node\Stmt\Class_), Array, Object(PHPStan\Analyser\MutatingScope), Object(PHPStan\Node\ClassStatementsGatherer), Object(PHPStan\Analyser\StatementContext))
Screenshot

Screenshot 2024-01-21 at 4 02 54 PM
spaze added a commit that referenced this issue Jan 22, 2024
@spaze
Support dynamic class constant fetch available in PHP 8.3
c0db6ec 
https://wiki.php.net/rfc/dynamic_class_constant_fetch

Fix #241
spaze added a commit that referenced this issue Jan 22, 2024
@spaze
Support dynamic class constant fetch available in PHP 8.3
bbe8fdf 
https://wiki.php.net/rfc/dynamic_class_constant_fetch

Fix #241
@spaze spaze mentioned this issue Jan 22, 2024
Merged
spaze added a commit that referenced this issue Jan 22, 2024
@spaze
Support dynamic class constant fetch available in PHP 8.3
a1810ec 
https://wiki.php.net/rfc/dynamic_class_constant_fetch

Fix #241
spaze added a commit that referenced this issue Jan 22, 2024
@spaze
Support dynamic class constant fetch available in PHP 8.3 (#242)
21e928d 
https://wiki.php.net/rfc/dynamic_class_constant_fetch

Fix #241

This should have been done in #217 already.
@spaze
Copy link
Owner

spaze commented Jan 22, 2024

Thanks @koraga, fixed the issue, will release it later today.

@spaze
Copy link
Owner

spaze commented Jan 22, 2024

Released in 3.1.0 now. Thanks again!

@koraga
Copy link
Author

koraga commented Jan 22, 2024 •
edited

I installed 3.1.0 but catch same error :(

For example my real code:

Screenshot

Screenshot 2024-01-22 at 11 00 19 PM
Screenshot 2024-01-22 at 10 58 34 PM

<?php

declare(strict_types=1);

namespace Modules\Admin\Http\Requests\AccessList;

use Illuminate\Foundation\Http\FormRequest;

/**
 * @property non-empty-string $type
 */
final class DownloadAccessListRequest extends FormRequest
{
    public function getType(): AccessListType
    {
        return AccessListType::{$this->type};
    }
}

// ...

enum AccessListType
{
    case White;
    case Black;
}

phpstan debug:

-- ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
     Error                                                                                                                                                                                                                    
 -- ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
     Internal error: Internal error: $node->name should be PhpParser\Node\Identifier but is PhpParser\Node\Expr\PropertyFetch while analysing file /api/Modules/Admin/Http/Requests/AccessList/DownloadAccessListRequest.php  
                                                                                                                                                                                                                              
     Post the following stack trace to https://github.com/phpstan/phpstan/issues/new?template=Bug_report.yaml:                                                                                                                
     ## /api/vendor/spaze/phpstan-disallowed-calls/src/Usages/ClassConstantUsages.php(99)                                                                                                                                     
     #0 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/FileAnalyser.php(107): Spaze\PHPStan\Rules\Disallowed\Usages\ClassConstantUsages->processNode(Object(PhpParser\Node\Expr\ClassConstFetch),               
     Object(PHPStan\Analyser\MutatingScope))                                                                                                                                                                                  
     #1 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Node/ClassStatementsGatherer.php(108): PHPStan\Analyser\FileAnalyser->PHPStan\Analyser\{closure}(Object(PhpParser\Node\Expr\ClassConstFetch),                     
     Object(PHPStan\Analyser\MutatingScope))                                                                                                                                                                                  
     #2 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(567): PHPStan\Node\ClassStatementsGatherer->__invoke(Object(PhpParser\Node\Expr\ClassConstFetch),                                  
     Object(PHPStan\Analyser\MutatingScope))                                                                                                                                                                                  
     #3 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(2653): PHPStan\Analyser\NodeScopeResolver::PHPStan\Analyser\{closure}(Object(PhpParser\Node\Expr\ClassConstFetch),                 
     Object(PHPStan\Analyser\MutatingScope))                                                                                                                                                                                  
     #4 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(1592): PHPStan\Analyser\NodeScopeResolver->callNodeCallbackWithExpression(Object(Closure),                                         
     Object(PhpParser\Node\Expr\ClassConstFetch), Object(PHPStan\Analyser\MutatingScope), Object(PHPStan\Analyser\ExpressionContext))                                                                                         
     #5 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(605): PHPStan\Analyser\NodeScopeResolver->processExprNode(Object(PhpParser\Node\Stmt\Return_),                                     
     Object(PhpParser\Node\Expr\ClassConstFetch), Object(PHPStan\Analyser\MutatingScope), Object(Closure), Object(PHPStan\Analyser\ExpressionContext))                                                                        
     #6 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(401): PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\Return_),                                     
     Object(PHPStan\Analyser\MutatingScope), Object(Closure), Object(PHPStan\Analyser\StatementContext))                                                                                                                      
     #7 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(566): PHPStan\Analyser\NodeScopeResolver->processStmtNodes(Object(PhpParser\Node\Stmt\ClassMethod), Array,                         
     Object(PHPStan\Analyser\MutatingScope), Object(Closure), Object(PHPStan\Analyser\StatementContext))                                                                                                                      
     #8 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(401): PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\ClassMethod),                                 
     Object(PHPStan\Analyser\MutatingScope), Object(PHPStan\Node\ClassStatementsGatherer), Object(PHPStan\Analyser\StatementContext))                                                                                         
     #9 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(668): PHPStan\Analyser\NodeScopeResolver->processStmtNodes(Object(PhpParser\Node\Stmt\Class_), Array,                              
     Object(PHPStan\Analyser\MutatingScope), Object(PHPStan\Node\ClassStatementsGatherer), Object(PHPStan\Analyser\StatementContext))                                                                                         
     #10 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(401): PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\Class_),                                     
     Object(PHPStan\Analyser\MutatingScope), Object(Closure), Object(PHPStan\Analyser\StatementContext))                                                                                                                      
     #11 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(640): PHPStan\Analyser\NodeScopeResolver->processStmtNodes(Object(PhpParser\Node\Stmt\Namespace_), Array,                         
     Object(PHPStan\Analyser\MutatingScope), Object(Closure), Object(PHPStan\Analyser\StatementContext))                                                                                                                      
     #12 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/NodeScopeResolver.php(370): PHPStan\Analyser\NodeScopeResolver->processStmtNode(Object(PhpParser\Node\Stmt\Namespace_),                                 
     Object(PHPStan\Analyser\MutatingScope), Object(Closure), Object(PHPStan\Analyser\StatementContext))                                                                                                                      
     #13 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Analyser/FileAnalyser.php(166): PHPStan\Analyser\NodeScopeResolver->processNodes(Array, Object(PHPStan\Analyser\MutatingScope), Object(Closure))                 
     #14 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Command/WorkerCommand.php(132): PHPStan\Analyser\FileAnalyser->analyseFile('/api/Modules/Ad...', Array, Object(PHPStan\Rules\LazyRegistry),                      
     Object(PHPStan\Collectors\Registry), NULL)                                                                                                                                                                               
     #15 phar:///api/vendor/phpstan/phpstan/phpstan.phar/vendor/evenement/evenement/src/Evenement/EventEmitterTrait.php(97): PHPStan\Command\WorkerCommand->PHPStan\Command\{closure}(Array)                                  
     #16 phar:///api/vendor/phpstan/phpstan/phpstan.phar/vendor/clue/ndjson-react/src/Decoder.php(117): _PHPStan_3d4486d07\Evenement\EventEmitter->emit('data', Array)                                                        
     #17 phar:///api/vendor/phpstan/phpstan/phpstan.phar/vendor/evenement/evenement/src/Evenement/EventEmitterTrait.php(97): _PHPStan_3d4486d07\Clue\React\NDJson\Decoder->handleData(Array)                                  
     #18 phar:///api/vendor/phpstan/phpstan/phpstan.phar/vendor/react/stream/src/Util.php(62): _PHPStan_3d4486d07\Evenement\EventEmitter->emit('data', Array)                                                                 
     #19 phar:///api/vendor/phpstan/phpstan/phpstan.phar/vendor/evenement/evenement/src/Evenement/EventEmitterTrait.php(97):                                                                                                  
     _PHPStan_3d4486d07\React\Stream\Util::_PHPStan_3d4486d07\React\Stream\{closure}('{"action":"anal...')                                                                                                                    
     #20 phar:///api/vendor/phpstan/phpstan/phpstan.phar/vendor/react/stream/src/DuplexResourceStream.php(154): _PHPStan_3d4486d07\Evenement\EventEmitter->emit('data', Array)                                                
     #21 phar:///api/vendor/phpstan/phpstan/phpstan.phar/vendor/react/event-loop/src/StreamSelectLoop.php(201): _PHPStan_3d4486d07\React\Stream\DuplexResourceStream->handleData(Resource id #6235)                           
     #22 phar:///api/vendor/phpstan/phpstan/phpstan.phar/vendor/react/event-loop/src/StreamSelectLoop.php(173): _PHPStan_3d4486d07\React\EventLoop\StreamSelectLoop->waitForStreamActivity(NULL)                              
     #23 phar:///api/vendor/phpstan/phpstan/phpstan.phar/src/Command/WorkerCommand.php(98): _PHPStan_3d4486d07\React\EventLoop\StreamSelectLoop->run()                                                                        
     #24 phar:///api/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Command/Command.php(259): PHPStan\Command\WorkerCommand->execute(Object(_PHPStan_3d4486d07\Symfony\Component\Console\Input\ArgvInput),        
     Object(_PHPStan_3d4486d07\Symfony\Component\Console\Output\ConsoleOutput))                                                                                                                                               
     #25 phar:///api/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(870):                                                                                                                         
     _PHPStan_3d4486d07\Symfony\Component\Console\Command\Command->run(Object(_PHPStan_3d4486d07\Symfony\Component\Console\Input\ArgvInput), Object(_PHPStan_3d4486d07\Symfony\Component\Console\Output\ConsoleOutput))       
     #26 phar:///api/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(261): _PHPStan_3d4486d07\Symfony\Component\Console\Application->doRunCommand(Object(PHPStan\Command\WorkerCommand),           
     Object(_PHPStan_3d4486d07\Symfony\Component\Console\Input\ArgvInput), Object(_PHPStan_3d4486d07\Symfony\Component\Console\Output\ConsoleOutput))                                                                         
     #27 phar:///api/vendor/phpstan/phpstan/phpstan.phar/vendor/symfony/console/Application.php(157):                                                                                                                         
     _PHPStan_3d4486d07\Symfony\Component\Console\Application->doRun(Object(_PHPStan_3d4486d07\Symfony\Component\Console\Input\ArgvInput), Object(_PHPStan_3d4486d07\Symfony\Component\Console\Output\ConsoleOutput))         
     #28 phar:///api/vendor/phpstan/phpstan/phpstan.phar/bin/phpstan(124): _PHPStan_3d4486d07\Symfony\Component\Console\Application->run()                                                                                    
     #29 phar:///api/vendor/phpstan/phpstan/phpstan.phar/bin/phpstan(125): _PHPStan_3d4486d07\{closure}()                                                                                                                     
     #30 /api/vendor/phpstan/phpstan/phpstan(8): require('phar:///api/ven...')                                                                                                                                                
     #31 /api/vendor/bin/phpstan(119): include('/api/vendor/php...')                                                                                                                                                          
     #32 {main}

@spaze
Copy link
Owner

spaze commented Jan 22, 2024

Oh, a PhpParser\Node\Expr\PropertyFetch:

return AccessListType::{$this->type};

I see, I'll fix, and sorry for the trouble.

Btw, can you please post the code as code next time, not as a screenshot? It helps when I'm for example checking the issue on my mobile, or when I'm searching for things in the future or so. I have OCR'd the original description for the same reason.

@spaze spaze reopened this Jan 22, 2024
spaze added a commit that referenced this issue Jan 22, 2024
@spaze
Support all Expr nodes when in dynamic constant fetch
0326e37 
Because besides `Variable`, there's also `PropertyFetch` (`Foo::{$this->type}`), `StaticPropertyFetch` (`Foo::{Foo::$bar}`) and more.

Fix #241, again.
@spaze spaze mentioned this issue Jan 22, 2024
Merged
spaze added a commit that referenced this issue Jan 22, 2024
@spaze
Support all Expr nodes when in dynamic constant fetch
43e9213 
Because besides `Variable`, there's also `PropertyFetch` (`Foo::{$this->type}`), `StaticPropertyFetch` (`Foo::{Foo::$bar}`) and more.

Fix #241, again.
spaze added a commit that referenced this issue Jan 22, 2024
@spaze
Support all Expr nodes when in dynamic constant fetch (#248)
fe56632 
Because besides `Variable`, there's also
- `PropertyFetch` (`Foo::{$this->type}`)
- `StaticPropertyFetch` (`Foo::{Foo::$bar}`)
- and more.

Fix #241, again.
@koraga
Copy link
Author

koraga commented Jan 22, 2024

Btw, can you please post the code as code next time, not as a screenshot? It helps when I'm for example checking the issue on my mobile, or when I'm searching for things in the future or so. I have OCR'd the original description for the same reason.

Okay, sorry

@spaze
Copy link
Owner

spaze commented Jan 22, 2024 •
edited

No problem and thanks for updating the comment! :-)

I have now fixed this (again!), hopefully for good this time 😅 Fix in 3.1.1 which replaces 3.1.0

Please let me know if it's alright, thanks.

@koraga
Copy link
Author

koraga commented Jan 22, 2024

It work! Thanks!

@spaze
Copy link
Owner

spaze commented Jan 23, 2024

Awesome, thanks for the confirmation! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@spaze @koraga