Require symfony/polyfill-php80 for dev/tests #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better than to have `@requires function str_starts_with` in each test that would need it because the number of tests will grow and you can't tell if the test needs str_starts_with() until you run the test on a PHP version without the function. This way it's more general and slightly more visible maybe. See phpstan/phpstan#9300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better than to have
@requires function str_starts_within each test that would need it because the number of tests will grow and you can't tell if the test needs str_starts_with() until you run the test on a PHP version without the function.This way it's more general and slightly more visible maybe.
See phpstan/phpstan#9300