New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native LIKWID Instrumentation #1063
Conversation
9926fba
to
cee9a97
Compare
cd8db17
to
f95aae6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, looks good. Your PR removed an important feature from instrumentation reporting, though, and the sample / feature is not documented enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking much better! Minor comments remain.
b6939f4
to
2d4c6c0
Compare
Okay, we're now following stricter contribution guidelines. That's good, the better things can be understood by new people, the better for us |
18ee6b0
to
cd52b75
Compare
cd52b75
to
51b70c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR for supporting LIKWID instrumentation in DaCe. The implementation is self-contained in the sense that it does not need to be wrapped by the likwid-perfctr tool.
The available groups (events + metrics) for each architecture can be found in likwid's groups folder, e.g. Skylake