BatchedMatMul: MKL gemm_batch support #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbennun
requested changes
Dec 18, 2022
| MKL_INT ldb_array[group_count] = {{ {ldb} }}; | ||
| MKL_INT ldc_array[group_count] = {{ {ldc} }}; | ||
|
|
||
| const {dtype}** A = new const {dtype}*[{BATCH}]; |
There was a problem hiding this comment.
why malloc in the middle of a potentially performance-critical code??
There was a problem hiding this comment.
btw that's the reason why we didn't implement it thus far.
|
you can try adding the allocation to the init code (if it depends on input symbols or is constant) or the stack (if the batch size is known and small) |
I don't know how to move this part to the init part. For BERT with batch size 6-8, the old implementation is much slower than this version |
tbennun
approved these changes
Mar 16, 2023
|
I'll approve for now, but this should probably use some inflatable workspace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.