Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DaCe Profiler #1197

Merged
merged 29 commits into from Mar 6, 2023
Merged

DaCe Profiler #1197

merged 29 commits into from Mar 6, 2023

Conversation

tbennun
Copy link
Collaborator

@tbennun tbennun commented Feb 20, 2023 •
edited

Implementation of https://github.com/orgs/spcl/projects/2/views/1

  • Refactor CLI optimization and profiling into general hook API
  • Fix bug discovered in GPUTransformLocalStorage when adding hook API (which added a .validate() call)
  • New command-line interface for profiling called daceprof
    • Profiling capabilities for arbitrary scripts and modules
      • Support for warmup and sequential mode
    • Reading/printing reports
    • CSV printout
    • Filtering capabilities
    • Instrumentation and data instrumentation capabilities
    • Interactive mode for filtering (v2)

tbennun and others added 28 commits December 18, 2022 09:20
@tbennun
Add interface for SDFG and compiled SDFG call hooks
4a5d3ab
@tbennun
Refactor profiling and CLI optimization into general hooks
d1a9a14
@tbennun
Merge remote-tracking branch 'origin/master' into sdprof
78799c3
@tbennun
Merge branch 'sdprof' of github.com:spcl/dace into sdprof
a9c5e21 
# Conflicts:
#	dace/frontend/operations.py
#	dace/hooks.py
@tbennun
Take care of double profiling corner case
5233212
@tbennun
Minor test fixes
36a1c86
@tbennun
Fix argument
aae7668
@tbennun
First version of daceprof
7e19fc5
@tbennun
daceprof: Disable OpenMP mode (--sequential)
1e2dc12
@tbennun
Add warmup iterations to profiler
20fbde0
@tbennun
Fix built-in hook imports
78f6778
@tbennun
Merge remote-tracking branch 'origin/master' into sdprof
6a2171a
@tbennun
Add missing file
6d7c250
@tbennun
Fix bug uncovered in GPU transformation
b3aaa35
@tbennun
Fix documentation and old API call
ed3e00c
@tbennun
Report CSV export and printout
03e2d22
@tbennun
Argument option refinement
dbb9984
@tbennun
Enable saving instrumentation reports from Python
0bc8ee2
@tbennun
Consolidate csdfg Python timers and instrumentation report format
11415a6
@tbennun
Minor fix
66ee43e
@tbennun
Instrumentation execution hook with filtering
a0fec40
@tbennun
daceprof: Support filtering and saving instrumentation reports
52b4025
@tbennun
Fix CSV saving for reports
679641f
@tbennun
Data instrumentation hooks and daceprof support
64ba625
@tbennun
Add current SDFG call hooks to program caching
dad4988
@tbennun
Merge branch 'master' into sdprof
62dc4fd
@tbennun
Test fix
7eb3428
@tbennun
Documentation
f496dec
@tbennun tbennun marked this pull request as ready for review March 6, 2023 03:49
@tbennun tbennun requested a review from phschaad March 6, 2023 03:49
@tbennun tbennun enabled auto-merge March 6, 2023 06:53
@tbennun tbennun disabled auto-merge March 6, 2023 06:53
@tbennun tbennun enabled auto-merge March 6, 2023 06:54
@phschaad phschaad disabled auto-merge March 6, 2023 09:18
phschaad
phschaad approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@phschaad phschaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition, thank you! Only small questions, otherwise LGTM.

Accepted but disabled auto-merge to ensure Qs are answered

setup.py Show resolved Hide resolved
tutorials/transformations.ipynb Outdated Show resolved Hide resolved
tutorials/transformations.ipynb Outdated Show resolved Hide resolved
dace/transformation/dataflow/gpu_transform_local_storage.py Show resolved Hide resolved
dace/codegen/instrumentation/report.py Show resolved Hide resolved
@tbennun tbennun enabled auto-merge March 6, 2023 15:27
@tbennun tbennun merged commit df2aea9 into master Mar 6, 2023
@tbennun tbennun deleted the sdprof branch March 6, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phschaad phschaad phschaad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Better `sdprof`
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tbennun @phschaad