Conditional Data Instrumentation #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbennun
requested changes
Mar 1, 2023
| @@ -106,6 +106,11 @@ def on_node_end(self, sdfg: SDFG, state: SDFGState, node: nodes.AccessNode, oute | |||
| # Only run on host code | |||
| return | |||
|
|
|||
| condition_preamble, condition_postamble = '', '' | |||
| if node.instrument_condition is not None and not node.instrument_condition.as_string == '1': | |||
| condition_preamble = f'if ({node.instrument_condition.as_string})' + ' {' | |||
There was a problem hiding this comment.
Please check how we generate C++ from codeblocks
There was a problem hiding this comment.
Learned something new, thanks.. :-)
| @@ -178,6 +185,11 @@ def on_node_begin(self, sdfg: SDFG, state: SDFGState, node: nodes.AccessNode, ou | |||
| # Only run on host code | |||
| return | |||
|
|
|||
| condition_preamble, condition_postamble = '', '' | |||
| if node.instrument_condition is not None and not node.instrument_condition.as_string == '1': | |||
| condition_preamble = f'if ({node.instrument_condition.as_string})' + ' {' | |||
| for node, _ in sdfg.all_nodes_recursive(): | ||
| if isinstance(node, nodes.AccessNode): | ||
| node.instrument = dace.DataInstrumentationType.Save | ||
| node.instrument_condition = CodeBlock('i == 0', language=dace.Language.CPP) |
There was a problem hiding this comment.
For completeness, please add a test with python codeblocks and “i ** 2 == 4”
Co-authored-by: Tal Ben-Nun <tbennun@users.noreply.github.com>
tbennun
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.