Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map-fission-single-data-multi-connectors #1216

Merged
merged 5 commits into from Mar 15, 2023

Conversation

alexnick83
Copy link
Contributor

When fissioning a Map with a single nested SDFG in its body, there is a bug when reconnecting the AccessNodes around the Map to the NestedSDFG node. If an AccessNode has outgoing edges to more than one NestedSDFG connector, then only one will be reconnected. This PR addresses this issue.

Copy link
Contributor

@acalotoiu acalotoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Should we keep the old code as comments in the fixed code?
I would suggest removing it altogether.

@alexnick83
Copy link
Contributor Author

Looks good to me. Should we keep the old code as comments in the fixed code? I would suggest removing it altogether.

Oh, I have commented-out tests. I will fix this first.

@alexnick83 alexnick83 merged commit 0e4066d into master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants