Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assortment of fixes for dynamic Maps on GPU (dynamic thread blocks) #1246

Merged
merged 6 commits into from Apr 28, 2023
Merged

Assortment of fixes for dynamic Maps on GPU (dynamic thread blocks) #1246

merged 6 commits into from Apr 28, 2023

Conversation

alexnick83
Copy link
Contributor

@alexnick83 alexnick83 commented Apr 28, 2023 •
edited

This PR addresses the following issues:

  • Adds support for dynamic thread blocks with step > 1.
  • Adds missing dynamic Map inputs definitions in the CUDA code generator (must be defined before and inside the dynamic Map GPU schedule).
  • In the case of Maps with dynamic inputs and GPU Device schedule, puts their host-side invocation in a scope of their own to avoid potential naming clashes.

@alexnick83 alexnick83 requested a review from tbennun April 28, 2023 14:56
tbennun
tbennun approved these changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, cool PR!

@alexnick83 alexnick83 merged commit 532bc64 into master Apr 28, 2023
9 checks passed
@alexnick83 alexnick83 deleted the fix-dynamic-tb branch April 28, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun tbennun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexnick83 @tbennun