Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix writes to nested definitions #1287

Merged
merged 2 commits into from Jun 28, 2023
Merged

Fix writes to nested definitions #1287

merged 2 commits into from Jun 28, 2023

Conversation

alexnick83
Copy link
Contributor

Fixes a bug that renders subscripted accesses to data defined inside a nested scope (e.g., a Map) to full-range accesses to the same data.

acalotoiu
acalotoiu approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@acalotoiu acalotoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding a new test to test the functionality!

@acalotoiu acalotoiu merged commit e0dbdf6 into master Jun 28, 2023
9 checks passed
@tbennun tbennun deleted the fix-writes-to-nested-definitions branch July 17, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acalotoiu acalotoiu acalotoiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexnick83 @acalotoiu