Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mpi4py send/recv support and alltoall library node #1288

Merged
merged 10 commits into from Jul 7, 2023

Conversation

Com1t
Copy link
Contributor

@Com1t Com1t commented Jun 28, 2023

Summary

Added mpi4py send/recv support and alltoall library node

Description

Added replacements and unit tests for mpi4py.MPI.COMM_WORLD.Send and mpi4py.MPI.COMM_WORLD.Recv.
Implemented the library node and unit test for the alltoall collective.

Copy link
Contributor

@alexnick83 alexnick83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's also add to this PR a replacement for AlltoAll.

@tbennun
Copy link
Collaborator

tbennun commented Jun 30, 2023

@alexnick83 wouldn’t we rather use replaces_method of the mpi4py communicator object instead?

@alexnick83
Copy link
Contributor

@alexnick83 wouldn’t we rather use replaces_method of the mpi4py communicator object instead?

That would make sense only if the communicator Python object existed. We should prefer creating the communicators in C directly. Using a preexisting communicator could be interesting and it may be possible; mpi4py returns the Fortran ID of the communicators. However, I have not done any tests to see if passing this integer to C and calling MPI_Comm_f2c returns a working handle. Technically it should work.

@alexnick83 alexnick83 merged commit dd06eb6 into spcl:mpi4py Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants