Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SDFG.name a proper property #1289

Merged
merged 1 commit into from Jun 29, 2023
Merged

Make SDFG.name a proper property #1289

merged 1 commit into from Jun 29, 2023

Conversation

phschaad
Copy link
Collaborator

@phschaad phschaad commented Jun 28, 2023 •
edited by tbennun

Fixes #28

@phschaad phschaad marked this pull request as ready for review June 29, 2023 04:53
tbennun
tbennun approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, truly one of the most revolutionary PRs I've seen

@phschaad
Copy link
Collaborator Author

Dace is really hitting its stride

@phschaad phschaad merged commit 672fc30 into master Jun 29, 2023
9 checks passed
@phschaad phschaad deleted the propertyify_sdfg_name branch June 29, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun tbennun approved these changes

@alexnick83 alexnick83 Awaiting requested review from alexnick83

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDFG.name should be a property
2 participants
@phschaad @tbennun