Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation improvements for Scalars. #1341

Merged
merged 6 commits into from Aug 3, 2023
Merged

Validation improvements for Scalars. #1341

merged 6 commits into from Aug 3, 2023

Conversation

alexnick83
Copy link
Contributor

@alexnick83 alexnick83 commented Aug 2, 2023 •
edited

  • Removes validation skip for Scalars in nested SDFGs.

Expected to fix #1334

@alexnick83 alexnick83 marked this pull request as ready for review August 3, 2023 11:43
@alexnick83 alexnick83 requested a review from tbennun August 3, 2023 11:44
tbennun
tbennun approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@alexnick83 alexnick83 merged commit 7ce5fdb into master Aug 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun tbennun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation does not catch transient=False on scalar result in nsdfg
2 participants
@alexnick83 @tbennun