Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Object to defined types in code generation and some documentation #1343

Merged
merged 2 commits into from Aug 4, 2023

Conversation

tbennun
Copy link
Collaborator

@tbennun tbennun commented Aug 3, 2023

No description provided.

@tbennun tbennun requested a review from acalotoiu August 3, 2023 14:37
Copy link
Contributor

@acalotoiu acalotoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Still not a fan of having references, and we might need to flag/discuss how to write transformations in their presence.

@tbennun
Copy link
Collaborator Author

tbennun commented Aug 4, 2023

Not the same kind of references :) these are c++ by-reference parameters. Before that we could only do scalars by value (which would copy the object around) or arrays by pointer (in which case we would dereference that object which would fail compilation)

@tbennun tbennun merged commit 425fed6 into master Aug 4, 2023
9 checks passed
@tbennun tbennun deleted the definedtype-object branch August 4, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants