Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace |& which is not widely supported #1399

Merged
merged 2 commits into from
Oct 19, 2023
Merged

replace |& which is not widely supported #1399

merged 2 commits into from
Oct 19, 2023

Commits on Oct 17, 2023

  1. replace |& which is not widely supported, i.e., on my local version o… 

    …f bash this fails with a syntax error
    @tim0s
    tim0s committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    6e21028 View commit details
    Browse the repository at this point in the history

  2. do not hardcode c++ compiler in test script 

    The test_all.sh script currently runs cpp tests using g++.
This is not good for the following reasons:
* During normal DaCe compilation we use cmake (and thus whatever compiler cmake picks up).
* We don't check if g++ is available.

This change uses whatever the user set as CXX env var. Cmake also uses CXX when it is set.
Thus if a user sets CXX, he will use the same compiler for tests and during dace compilation.
If CXX is not set we fall back to g++ as the hard-coded compiler.

The test script also prints the current progress before each test now.
    @tim0s
    tim0s committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    d97c842 View commit details
    Browse the repository at this point in the history