Fixes for TaskletFusion, AugAssignToWCR and MapExpansion #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lukastruemper
commented
Nov 16, 2023
•
lukastruemper
commented
- The PR fixes two minor bugs for corner cases of the AugAssignToWCR and TaskletFusion which are reflected in additional test cases:
- TaskletFusion: Should not remove array from SDFG, since it could be used elsewhere
- AugAssignToWCR: Handle tasklets where all inputs come from same array
- The PR re-writes MapExpansion to create only one memlet path per out connector to be more efficient. I experienced MapExpansion running for literally hours because it uses add_memlet_path for each edge to a tasklet. This is too expensive for >4 dimensional stencils with >50 edges
lukastruemper
force-pushed
the
users/lukas/bugfixes
branch
from
276348f
to
5ef99e0
Compare
lukastruemper
changed the title
phschaad
approved these changes
Nov 25, 2023
lukastruemper
added a commit
that referenced
this pull request
Nov 26, 2023
- The PR fixes two minor bugs for corner cases of the AugAssignToWCR and TaskletFusion which are reflected in additional test cases: - TaskletFusion: Should not remove array from SDFG, since it could be used elsewhere - AugAssignToWCR: Handle tasklets where all inputs come from same array - The PR re-writes MapExpansion to create only one memlet path per out connector to be more efficient. I experienced MapExpansion running for literally hours because it uses add_memlet_path for each edge to a tasklet. This is too expensive for >4 dimensional stencils with >50 edges
lukastruemper
added a commit
that referenced
this pull request
Dec 2, 2023
- The PR fixes two minor bugs for corner cases of the AugAssignToWCR and TaskletFusion which are reflected in additional test cases: - TaskletFusion: Should not remove array from SDFG, since it could be used elsewhere - AugAssignToWCR: Handle tasklets where all inputs come from same array - The PR re-writes MapExpansion to create only one memlet path per out connector to be more efficient. I experienced MapExpansion running for literally hours because it uses add_memlet_path for each edge to a tasklet. This is too expensive for >4 dimensional stencils with >50 edges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.