OTFMapFusion: Minor bug fixes #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just pushed an additional fix |
lukastruemper
commented
Nov 25, 2023
| if graph.out_degree(self.first_map_exit) > 1: | ||
| return False | ||
| if graph.in_degree(self.array) > 1: | ||
| return False | ||
|
|
||
| # Check if array is overwritten afterwards | ||
| subset = next(graph.out_edges(self.first_map_exit).__iter__()).data.subset |
There was a problem hiding this comment.
Would be happy to use helper functions for this. It could be less conservative.
There was a problem hiding this comment.
Maybe something like is_shadowed for an access node
There was a problem hiding this comment.
The more I think about this, the more I am convinced that the transformation should be simple and we need to write a „ShadowedAccessNode“ Pass
There was a problem hiding this comment.
Reverted the changes; We need a strategy for MapFusion, OTFMapFusion and TakletFusion. The transformations should be simple and be used with certain analysis passes
lukastruemper
force-pushed
the
otf-fix
branch
from
87373ae
to
ff9e2e2
Compare
tbennun
approved these changes
Nov 26, 2023
lukastruemper
added a commit
that referenced
this pull request
Dec 2, 2023
This PR fixes the problem that data containers were removed from an SDFG, although they might be used in another state. Furthermore, it fixes the problem that self.second_map_entry may not point to the correct node after adding/removing nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem that data containers were removed from an SDFG, although they might be used in another state. Furthermore, it fixes the problem that self.second_map_entry may not point to the correct node after adding/removing nodes