Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not serialize non-default fields by default #1452

Merged
merged 11 commits into from Dec 4, 2023
Merged

Conversation

tbennun
Copy link
Collaborator

@tbennun tbennun commented Nov 27, 2023

Added a configuration entry (enabled by default) that serializes only the modified fields in an SDFG. This leads to a reduction in size.

Merging this PR is contingent on updating the SDFG renderer to use the defaults/metadata for properties.

@tbennun tbennun marked this pull request as draft November 27, 2023 16:10
@tbennun tbennun marked this pull request as ready for review November 28, 2023 15:46
@tbennun
Copy link
Collaborator Author

tbennun commented Nov 29, 2023

@phschaad do not merge until a release (not prerelease) of sdfv and the vscode plugin are both done.

@phschaad phschaad enabled auto-merge (squash) December 4, 2023 09:21
@phschaad phschaad enabled auto-merge (squash) December 4, 2023 09:22
@phschaad phschaad merged commit 6374843 into master Dec 4, 2023
9 checks passed
@phschaad phschaad deleted the save-nondefault branch December 4, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants