Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDFG.arg_names was not a member but a class variable. #1457

Merged
merged 1 commit into from Nov 29, 2023

Conversation

philip-paul-mueller
Copy link
Collaborator

The member variable arg_names was not created in the constructor. Thus a class variable was created instead which was shared among all instances.

@philip-paul-mueller
Copy link
Collaborator Author

According to my understanding the reason why it has not surfaced yet is due to dace/frontend/python/parser.py:903.

The member variable `arg_names` was not created in the constructor.
Thus a class variable was created instead which was shared among all instances.
philip-paul-mueller added a commit to philip-paul-mueller/gt4py that referenced this pull request Nov 29, 2023
…erator` and related problems.

GT4Py started to exhibit an issue (out of bounds access) with the introduction of [PR1457](spcl/dace#1457).
The commit fixes this, by creating the proper arguments and ensuring that the memory it operates on is continuous and proper allocated.
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tbennun tbennun merged commit 16c569b into spcl:master Nov 29, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants