Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jupyter fix #1489

Merged
merged 7 commits into from
Feb 16, 2024
Merged

Jupyter fix #1489

merged 7 commits into from
Feb 16, 2024

Conversation

phschaad
Copy link
Collaborator

No description provided.

@tbennun
Copy link
Collaborator

tbennun commented Dec 30, 2023

Once this is done please merge #1438.

@phschaad phschaad marked this pull request as ready for review January 15, 2024 12:18
@phschaad phschaad requested a review from tbennun January 15, 2024 12:18
@tbennun tbennun added the in the merge queue waiting for CI to work again label Jan 15, 2024
tbennun
tbennun approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@tbennun tbennun left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but please redirect sdfv.js to a Jupyter-specific version, as well as update the webclient repo after merging to its respective master. Thanks!

@phschaad phschaad requested a review from tbennun January 15, 2024 21:17
@phschaad phschaad mentioned this pull request Feb 7, 2024
Open
@phschaad phschaad added this pull request to the merge queue Feb 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 16, 2024
@phschaad phschaad added this pull request to the merge queue Feb 16, 2024
@tbennun tbennun removed this pull request from the merge queue due to the queue being cleared Feb 16, 2024
@tbennun tbennun merged commit 47ef29a into master Feb 16, 2024
11 checks passed
@tbennun tbennun deleted the jupyter_fix branch February 16, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun tbennun approved these changes

Assignees
No one assigned
Labels
in the merge queue waiting for CI to work again
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phschaad @tbennun