Backward Conversion #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Could you please follow the guide here: https://github.com/spcl/dace/blob/master/CONTRIBUTING.md Thanks! |
acalotoiu
requested changes
Jul 15, 2023
acalotoiu
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a partial backwards conversion pass (or a lowering pass) to the SDFG dialect, which can be called using
sdfg-opt --lower-sdfg. The tests folder structure has been adapted and additional tests have been added. Here is an overview of the operations and their implementation status in the converter:sdfg.sdfgsdfg.nested_sdfgsdfg.statesdfg.edge(with assignments and conditionals)sdfg.alloc(only array type with symbolic and constant sizes)sdfg.load(with symbolic and constant indices)sdfg.store(with symbolic and constant indices)sdfg.alloc_symbolsdfg.symsdfg.taskletsdfg.returnsdfg.map(with symbolic and constant bounds and step)sdfg.consumesdfg.subviewsdfg.view_castAll users of symbolic expressions (such as maps, edges, loads, stores, etc.) use a symbolic parser, which implements a lexer, parser and an internal AST to convert the symbolic expression to builtin MLIR operations.