Better, more configurable Docker support #25
Conversation
Added docker scripts for launching registry Created base docker image for the rFaas executable Changed the Executor Manager settings parser to allow for docker configuration
| @@ -22,7 +23,8 @@ set(CMAKE_CXX_STANDARD_REQUIRED TRUE) | |||
| string(REPLACE "-DNDEBUG" "" CMAKE_CXX_FLAGS_RELWITHDEBINFO "${CMAKE_CXX_FLAGS_RELWITHDEBINFO}") | |||
| string(APPEND CMAKE_CXX_FLAGS_RELWITHDEBINFO " -g -DSPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_DEBUG ") | |||
| string(APPEND CMAKE_CXX_FLAGS_DEBUG " -DSPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_DEBUG ") | |||
| string(APPEND CMAKE_CXX_FLAGS " -Wall -Wextra ") | |||
| string(APPEND CMAKE_CXX_FLAGS " -Wall -Wextra") | |||
| #string(APPEND CMAKE_CXX_FLAGS " -v -lstdc++") | |||
There was a problem hiding this comment.
Looks like a leftover :-) Did you have trouble with compiling rFaaS on machines with libc++?
There was a problem hiding this comment.
Perhaps my system was weirdly configured, but compilation with clang only worked with explicit linking of stdc++. However, compilation with gcc worked just fine, so I went with that.
There was a problem hiding this comment.
I think the binaries were added by accident.
We can change the CMake scripts to name our executables "cold_benchmarker.x" to help gitignore catch these.
There was a problem hiding this comment.
Apologies. I of course would make sure that the repository is clean before a merge.
| REG_IMG=$REG_IP:$REG_PORT/$IMG_NAME | ||
|
|
||
| # Build the docker container, login and push to the registry | ||
| sudo docker build -t $IMG_NAME - < containers/rfaas-base.Dockerfile |
There was a problem hiding this comment.
I think it might be simpler not to use sudo here and instead explain in the documentation that users to make sure that they have necessary permissions to run Docker. Furthermore, on clusters the user might be in the docker group but it it is very unlikely that they will have sudo access.
Also, it's safer if never request to execute anything with superuser permissions - less likely that any mistake will have bad consequences :)
There was a problem hiding this comment.
Okay. That is a great point. Principle of least privilege!
There was a problem hiding this comment.
Same comment as for executables :-)
| @@ -0,0 +1,3 @@ | |||
| #!/bin/bash | |||
|
|
|||
| sudo docker network create -d sriov --subnet=172.31.80.0/20 -o netdevice=eth0 mynet | |||
There was a problem hiding this comment.
The subnet should depend on your local network - maybe we can make it a parameter? Wrapping network initialization is definitely a good idea!
There was a problem hiding this comment.
Another idea: add a second parameter for two types of networking - sriov and host. This way we can easily support a simpler networking mode, at least for testing.
There was a problem hiding this comment.
I will definitely parameterize this.
|
@mattnappo Thank you! This looks like a good start :-) I have a similar but extended solution for container selection on a different branch ( |
mattnappo
changed the title
|
This has been moved to #29 |
This draft PR contributes to #10 and #19 by:
config/executor_manager.jsonconfiguration file serves as an example of how to configure the docker registry and container selection.Work that still needs to be done to wrap up Docker support:
Right now, the configuration system I added is capable of connecting to any registry. Of course, running a local registry on the same server as the executor manager is possible under this config.