Readme fix, added JSDoc string, Fixed updateActionData min/max Value when 0 raise error, and Don't validate removeState #26
Conversation
KillerBOSS2019
commented
Sep 30, 2022
KillerBOSS2019
commented
- Fixed readme ( fully working JS example )
- Added doc string for almost all of methods that describe args and return.
- Added removeStateMany()
- Fixed connect() so it uses arg instead of object
- Fixed CheckForUpdate() instead of using parent variable it's an arg.
- Fixed readme ( fully working JS example ) - Added doc string for almost all of methods that describe args and return. - Added removeStateMany() - Fixed connect() so it uses arg instead of object - Fixed CheckForUpdate() instead of using parent variable it's an arg.
|
Also sorry this took so long for me to review - I need to start using the Volta page more often. need to use that to keep track of all the stuff i need to work on for my TP plugins. |
|
Ah sorry I completely forgot about this. I'll fix that when I get on my PC. |
|
Good revert. But your merge clobbered #33 :-( |
|
I hate conflict lol |
|
Conflict sucks! ☮️ |
|
Okay.... hope that solves it. |
|
YES FINALLY PASSED one more to go hehe |
KillerBOSS2019
changed the title
|
Hi Damien, I fixed the conflicts, but TBH it would be great to just add the JS Docs as a standalone commit, w/out any functional changes. This adds real value on its own, especially with the strong VSCode/IDE type checking these days. I'll probably do something with those myself soon if no one else does... The README example fix would make sense in the same PR, but as its own commit (maybe it already is but I lost track... :) ). The update check changes are a fine fix/simplification but should be their on their own clean commit, at least, if not PR. Maybe even a good place to "sneak in" removing the useless And the state update helper... I'm ambivalent about that, but at the very least this part actually needs to be tested (and as far as I can tell no one has). Mixing it with unrelated changes is the main issue I have with this PR at this point. Thanks! |
