Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not validate if state exists in removeState() #33

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Do not validate if state exists in removeState() #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ class TouchPortalClient extends EventEmitter {
}

removeState(id) {
if (this.customStates[id] === undefined) {
this.logIt('ERROR', `removeState: Custom state of ${id} never created, so cannot remove it`);
throw new Error(`removeState: Custom state of ${id} never created, so cannot remove it`);
if (!id) {
this.logIt('ERROR', `removeState: ID parameter is empty`);
throw new Error(`removeState: ID parameter is empty`);
}
delete this.customStates[id];
this.send({
Expand Down