Fix for incomplete incoming messages from TP (w/out final newline). #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsing, otherwise buffer the data and wait for more; Also place a try/catch around `JSON.parse(line)`. Fixes errors/crashes with messages that are too large for the socket buffer, like when sending long action data (eg. base64 image) or in other cases where socket data builds up, eg. when plugin takes a long time to process a message or is paused in a debugger.
spdermn02
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Fixes errors/crashes with messages, or sets of messages, that are too large to fit into one socket buffer before
datahandler is called, resulting in no terminating newline.For example when sending long action data (eg. base64 image) or in other cases where socket data builds up, eg. when plugin takes a long time to process a message or is paused in a debugger. I've personally observed all 3 scenarios.
Also as a final check this puts a try/catch around the JSON parsing bit, which at least helps track down anything else unexpected that may happen (not that I've seen that).
Also turns out the
dataparameter of theon(data)handler was already a string. :) I kept it as a string since apparently it's significantly faster to extract parts of strings than Node Buffers. To make up for the possible buffering overhead, at least we get rid of an array allocation.-Max