Skip to content

Commit

Permalink
test/setup: Remove the hp_status() test
Browse files Browse the repository at this point in the history
This just verifies a modest setup.sh's output which is of little
relevance. On top of that, depending on the system's state, the
test itself may be flaky so get rid of it.

Signed-off-by: Michal Berger <michal.berger@intel.com>
Change-Id: Icc918a0dbbb54067c281aa465a097c4e40a32e11
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/13827
Reviewed-by: Pawel Piatek <pawelx.piatek@intel.com>
Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Reviewed-by: Jim Harris <james.r.harris@intel.com>
Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
  • Loading branch information
mikeBashStuff authored and tomzawadzki committed Aug 9, 2022
1 parent 327f69e commit ab356d4
Showing 1 changed file with 0 additions and 24 deletions.
24 changes: 0 additions & 24 deletions test/setup/hugepages.sh
Expand Up @@ -186,29 +186,6 @@ custom_alloc() {
nr_hugepages=$_nr_hugepages verify_nr_hugepages
}

hp_status() {
# Parse status from last verification

local node
local size free total

((${#nodes_sys[@]} > 0))

while read -r node size free _ total; do
size=${size/kB/} node=${node#node}
((size == default_hugepages)) || continue
((total == nodes_test[node]))
# If something grabbed hugepages we can't really do anything about it. Just skip the free check and leave
# a big warning.
if ((free != total)); then
printf '* %u free != %u total hugepages. Something is using hugepages, this may affect the test\n' \
"$free" "$total" >&2
continue
fi
((free == nodes_test[node]))
done < <(setup output status |& grep "node[0-9]")
}

get_nodes
clear_hp

Expand All @@ -217,6 +194,5 @@ run_test "per_node_2G_alloc" per_node_2G_alloc
run_test "even_2G_alloc" even_2G_alloc
run_test "odd_alloc" odd_alloc
run_test "custom_alloc" custom_alloc
run_test "hp_status" hp_status

clear_hp

0 comments on commit ab356d4

Please sign in to comment.