Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When will NvmeLunsPerNs is removed? #95

Closed
uchida2016 opened this issue Dec 21, 2016 · 3 comments
Closed

When will NvmeLunsPerNs is removed? #95

uchida2016 opened this issue Dec 21, 2016 · 3 comments
Labels
Milestone

Comments

@uchida2016
Copy link
Contributor

When nvme bdev is deleted by rpc.py with delete_lun option, coresponding nvme_device is not deleted.

ex: Nvme3n1p0 is on 0000:02:00.0
# ./scripts/rpc.py delete_lun Nvme3n1p0

Then I try to create bdev again by rpc.py with construct_nvme_bdev. But it fails because the nvme_device already existed.

# ./scripts/rpc.py construct_nvme_bdev 0000:02:00.0
Got JSON-RPC error response
request:
{
  "jsonrpc": "2.0",
  "params": {
    "pci_address": "0000:02:00.0"
  },
  "method": "construct_nvme_bdev",
  "id": 1
}
response:
{
  "message": "Invalid parameters",
  "code": -32602
}

I'd like to make a PR to delete nvme_device in blockdev_nvme_destruct.
Regarding to it, I have a question. Daniel mentioned that NvmeLunsPerNs option will be removed in #85. I want to wait for it, then make a PR. Would you tell me when NvmeLunsPerNs will be removed?

@ghost
Copy link

ghost commented Jan 13, 2017

The actual NvmeLunsPerNs removal is fairly trivial, but I am working on a more general replacement for this feature, since we still want to support splitting bdevs (e.g. for testing large numbers of independent LUNs); however, it will now be implemented as a generic "virtual blockdev" that can be layered on top of the NVMe bdev as well as other bdev types. I expect this work to be done within Q1, but I don't have an exact timeline.

Once this cleanup is complete, we should definitely be in a better position to correctly support removal of LUNs and bdevs.

@uchida2016
Copy link
Contributor Author

Thank you for the information. I need removal of LUNs and bdevs to be supported in next version 17.03.

@benlwalker benlwalker added this to the 17.03 milestone Jan 30, 2017
@ghost
Copy link

ghost commented Jan 30, 2017

NvmeLunsPerNs has been removed in commit efccac8.

@ghost ghost closed this as completed Jan 30, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants