Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punch List: Snippet #11

Closed
3 of 4 tasks
iamwillbar opened this issue Dec 8, 2021 · 4 comments
Closed
3 of 4 tasks

Punch List: Snippet #11

iamwillbar opened this issue Dec 8, 2021 · 4 comments
Labels
model Something about the abstract model Profile:Software

Comments

@iamwillbar
Copy link
Contributor

iamwillbar commented Dec 8, 2021

This is a punch list of open questions from the 2021-12-07 Tech Team meeting. Please comment on this issue with any discussion, proposed answers, or additional questions you have:

  • Define byte range, continue to follow W3C standard?
  • Define snippet location - possibly as abstract class: byte range, line range, W3C, etc.
  • Will snippet location class be able to model W3C
  • Review 2.2 Snippet to make sure not dropped.
@iamwillbar
Copy link
Contributor Author

  • Check with Sean what UCO uses for ranges within a file.
  • No strong desire to keep the W3C approach.

@goneall
Copy link
Member

goneall commented Feb 26, 2023

@iamwillbar In the model, there is a new property contentIdentifier with a type URI and the snippetFromFile is missing. Did we just rename the property? I couldn't find any record of this in the minutes.

@armintaenzertng
Copy link
Contributor

I just went over the 2.3 specification and made sure that the only properties not present in the 3.0 model are part of the Licensing profile and snippetFromFile, which is discussed in #130. As byteRange and lineRange are now defined as PositiveIntegerRange, I think this issue can be closed.

@maxhbr maxhbr added model Something about the abstract model Profile:Software labels Mar 24, 2023
@kestewart
Copy link
Contributor

@iamwillbar - am closing this issue. Please reopen if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model Something about the abstract model Profile:Software
Projects
None yet
Development

No branches or pull requests

5 participants