Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPDX 2.3 Support #156

Closed
lumjjb opened this issue Aug 26, 2022 · 10 comments · Fixed by #164
Closed

SPDX 2.3 Support #156

lumjjb opened this issue Aug 26, 2022 · 10 comments · Fixed by #164
Assignees
Milestone

Comments

@lumjjb
Copy link
Collaborator

lumjjb commented Aug 26, 2022

Implement SPDX 2.3 support (preferably waiting on #152) for refactor changes.

2.3 Link: https://spdx.github.io/spdx-spec/v2.3/

@lumjjb lumjjb added this to the 0.4.0 milestone Aug 26, 2022
@nishakm
Copy link

nishakm commented Sep 23, 2022

Need help with this? I need a 2.3 model to implement a generator :)

@lumjjb
Copy link
Collaborator Author

lumjjb commented Sep 23, 2022

that would be super helpful!!!!

@kzantow
Copy link
Collaborator

kzantow commented Sep 29, 2022

@nishakm I also need some of the new features of 2.3 -- could I help with this?

@nishakm
Copy link

nishakm commented Sep 29, 2022

@nishakm I also need some of the new features of 2.3 -- could I help with this?

Absolutely!

@lumjjb
Copy link
Collaborator Author

lumjjb commented Sep 29, 2022

Assigned the issue to bot of you!!! Thank you!!

@kzantow
Copy link
Collaborator

kzantow commented Oct 4, 2022

I'm starting to look at implementing this -- is there a document somewhere with the changes for 2.3?

@lumjjb
Copy link
Collaborator Author

lumjjb commented Oct 4, 2022

Awesome @kzantow !!!! Yes! Here's the changes from 2.2 (https://spdx.github.io/spdx-spec/v2.3/diffs-from-previous-editions/)! Is this something that's useful?

You can ignore the between v2.2.x versions because they are mainly documentation changes.

@kzantow kzantow mentioned this issue Oct 6, 2022
3 tasks
@kzantow
Copy link
Collaborator

kzantow commented Oct 6, 2022

@lumjjb I've added a draft PR with some initial changes for 2.3: namely a new v2_3 data model and JSON support, along with some other miscellaneous stuff. It does not yet have support for the other formats, but it will before I'd consider it done.

It should also be noted I found a number of issues with the v2_2 model that I corrected only in the v2_3 model -- namely many fields need to be omitempty. I used the JSON output and the current SPDX validator to track down a number of these issues. I may have missed some, but I think it's a lot better than the v2_2 model.

It looks like you did some of the refactoring for the current state of this repo, if you had a little time, could you have a quick look and make sure I'm on the right track before I complete everything else? This is probably the main commit to look at.

@kzantow
Copy link
Collaborator

kzantow commented Oct 10, 2022

@lumjjb I believe I've implemented all the 2.3 support in this PR: #164

@kzantow
Copy link
Collaborator

kzantow commented Oct 10, 2022

I've also added a refactoring suggestion I would like to do here: #165 I know there are some other things (like translating between versions) that people would like to see, but I feel that's a separate issue and the refactoring would dramatically improve the experience every time someone needs to implement a new SPDX version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants