Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build badges #35

Closed
swinslow opened this issue Jun 14, 2020 · 1 comment · Fixed by #37
Closed

Fix build badges #35

swinslow opened this issue Jun 14, 2020 · 1 comment · Fixed by #37
Labels
bug Something isn't working
Milestone
0.1.0

Comments

@swinslow
Copy link
Member

The current build badge is still pointing to Travis. It should point to the results of the GitHub Actions build instead.
@swinslow swinslow added the bug Something isn't working label Jun 14, 2020
@swinslow swinslow changed the title Fix build badge Fix build badges Jun 14, 2020
@swinslow
Copy link
Member Author

swinslow commented Jun 14, 2020 •
edited

Travis badge has been replaced, but the coveralls badge also appears to be pointing to perhaps the wrong image URL:

https://coveralls.io/repos/github/spdx/tools-golang/badge.svg

should perhaps instead be:

https://coveralls.io/repos/github/spdx/tools-golang/badge.svg?branch=master

EDITED: disregard, looks like the badge was just slow to update.

Also, the GitHub Actions badge link should probably go to the actual Actions page rather than just to the badge image file.

@swinslow swinslow mentioned this issue Jun 14, 2020
Merged
@swinslow swinslow added this to the 0.1.0 milestone Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Fix link for actions badge spdx/tools-golang
1 participant
@swinslow