Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use valid data in test fixtures #397

Closed
nicoweidner opened this issue Dec 30, 2022 · 3 comments
Closed

Use valid data in test fixtures #397

nicoweidner opened this issue Dec 30, 2022 · 3 comments
Labels
tests

Comments

@nicoweidner
Copy link
Collaborator

nicoweidner commented Dec 30, 2022 •
edited

Currently, test data used in fixtures does not pass validation. While not really necessary, it would be nice to use test data that passes our own validation.
See https://github.com/spdx/tools-python/pull/379/files#diff-5dbc88d6e5c3615caf10e32a9d6fc6ff683f5b5814948928cb84c3ab91c038b6

While at it, those fixtures should be unified with https://github.com/spdx/tools-python/blob/refactor-python-tools/tests/valid_defaults.py
@armintaenzertng armintaenzertng mentioned this issue Jan 4, 2023
Merged
@meretp
Copy link
Collaborator

meretp commented Jan 9, 2023

fixed with #409

@meretp meretp closed this as completed Jan 9, 2023
@meretp
Copy link
Collaborator

meretp commented Jan 9, 2023

reopen this as this TODO can't be fixed yet, turning the validation leads to a failing test.

@meretp meretp reopened this Jan 9, 2023
@meretp
Copy link
Collaborator

meretp commented Jan 12, 2023

fixed with #417

@meretp meretp closed this as completed Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meretp @nicoweidner