Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make validation optional by introducing a validate flag #60

Closed
yash-nisar opened this issue Apr 14, 2018 · 2 comments
Closed

Make validation optional by introducing a validate flag #60

yash-nisar opened this issue Apr 14, 2018 · 2 comments
Labels
enhancement validation An issue concerning the validation of SPDX documents

Comments

@yash-nisar
Copy link
Contributor

On the validation side, the validation will be an option. Fields will not be mandatory by default. They will be checked only when the user asks to validate and not at the time of creation. This will enforce the user to be able to create and dump eventually partial documents that may not yet be fully valid.

This can be established by introducing a validate flag in both the parsers (tagvalue and rdf) and validating only when the flag is set.

@pombredanne Should I create a PR for this one ?

@RishabhBhatnagar
Copy link

Hello there, this issue still persists??
If yes, I would like to resolve this.

@nicoweidner nicoweidner added the validation An issue concerning the validation of SPDX documents label Nov 4, 2022
@nicoweidner
Copy link
Collaborator

While the parser methods still don't have a validate flag (see e.g. this section), there doesn't seem to be a lot of people impacted by this shortcoming. I will close this for the time being; the upcoming refactoring will validate in a separate layer anyway, and we can add a flag there.

Please ping if this should be reopened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement validation An issue concerning the validation of SPDX documents
Projects
None yet
Development

No branches or pull requests

4 participants